This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "GNU gsasl".
http://git.savannah.gnu.org/cgit/gsasl.git/commit/?id=7e55269433985bf446e5c04b98a9434e1ac94814 The branch, master has been updated via 7e55269433985bf446e5c04b98a9434e1ac94814 (commit) via d099c7896b91bea675818165ba692b7d9fb0bb62 (commit) via f9f8054783b03b9efa573afff1e13c5db533b6e7 (commit) from b30c0b466604705a63e3a804dd9b4e7ce1edd8a6 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 7e55269433985bf446e5c04b98a9434e1ac94814 Author: Simon Josefsson <[email protected]> Date: Fri Sep 11 16:01:33 2009 +0200 SCRAM: Drop FIXME, specification changed to not use UTF-8 for nonces. commit d099c7896b91bea675818165ba692b7d9fb0bb62 Author: Simon Josefsson <[email protected]> Date: Fri Sep 11 15:59:45 2009 +0200 SCRAM: Drop FIXMEs, we solved it differently. commit f9f8054783b03b9efa573afff1e13c5db533b6e7 Author: Simon Josefsson <[email protected]> Date: Fri Sep 11 15:59:13 2009 +0200 SCRAM: Drop FIXMEs, we solved it differently. ----------------------------------------------------------------------- Summary of changes: lib/scram/parser.c | 6 ------ lib/scram/printer.c | 4 ---- lib/scram/validate.c | 6 ------ 3 files changed, 0 insertions(+), 16 deletions(-) diff --git a/lib/scram/parser.c b/lib/scram/parser.c index c3d0f2b..869289d 100644 --- a/lib/scram/parser.c +++ b/lib/scram/parser.c @@ -280,8 +280,6 @@ scram_parse_client_final (const char *str, memcpy (cl->cbind, str, len); cl->cbind[len] = '\0'; - /* FIXME base64 decode cbind */ - str = p; } @@ -334,8 +332,6 @@ scram_parse_client_final (const char *str, memcpy (cl->proof, str, len); cl->proof[len] = '\0'; - - /* FIXME base64 decode proof */ } if (scram_valid_client_final (cl) < 0) @@ -367,8 +363,6 @@ scram_parse_server_final (const char *str, memcpy (sl->verifier, str, len); sl->verifier[len] = '\0'; - - /* FIXME base64 decode verifier */ } if (scram_valid_server_final (sl) < 0) diff --git a/lib/scram/printer.c b/lib/scram/printer.c index dd59cc1..e515960 100644 --- a/lib/scram/printer.c +++ b/lib/scram/printer.c @@ -127,8 +127,6 @@ scram_print_client_final (struct scram_client_final *cl, char **out) if (!scram_valid_client_final (cl)) return -1; - /* FIXME base64 cbind/proof */ - n = asprintf (out, "c=%s,r=%s,p=%s", cl->cbind, cl->nonce, cl->proof); if (n <= 0 || *out == NULL) @@ -150,8 +148,6 @@ scram_print_server_final (struct scram_server_final *sl, char **out) if (!scram_valid_server_final (sl)) return -1; - /* FIXME base64 verifier */ - n = asprintf (out, "v=%s", sl->verifier); if (n <= 0 || *out == NULL) return -1; diff --git a/lib/scram/validate.c b/lib/scram/validate.c index 6f8cf74..9475473 100644 --- a/lib/scram/validate.c +++ b/lib/scram/validate.c @@ -65,8 +65,6 @@ scram_valid_client_first (struct scram_client_first *cf) if (strchr (cf->client_nonce, ',')) return false; - /* FIXME check that client nonce is valid UTF-8. */ - return true; } @@ -81,8 +79,6 @@ scram_valid_server_first (struct scram_server_first *sf) if (strchr (sf->nonce, ',')) return false; - /* FIXME check that nonce is valid UTF-8. */ - /* We require a non-zero salt. */ if (sf->salt == NULL || *sf->salt == '\0') return false; @@ -116,8 +112,6 @@ scram_valid_client_final (struct scram_client_final *cl) if (strchr (cl->nonce, ',')) return false; - /* FIXME check that nonce is valid UTF-8. */ - /* We require a non-zero proof. */ if (cl->proof == NULL || *cl->proof == '\0') return false; hooks/post-receive -- GNU gsasl _______________________________________________ Gsasl-commit mailing list [email protected] http://lists.gnu.org/mailman/listinfo/gsasl-commit
