On Sun, Nov 25, 2012 at 6:45 AM, Nimit Shah <[email protected]> wrote: > Hi Izidor! > The name should be Getting Things GNOME. Gettings is not correct English. > > On 11/25/12, Izidor Matušov <[email protected]> wrote: >> Hi everybody, >> >> I spent the morning on Friday on a bus and did some cleanup. I have >> proposed two merge requests:
Thanks a lot for that, that's great work!. >> https://code.launchpad.net/~izidor/gtg/eval-cleanup/+merge/136021 >> >> Get rid of eval() from GTG's codebase. It might be potentionally harmful. >> >> https://code.launchpad.net/~izidor/gtg/pep8/+merge/136022 >> >> PEP8-ification of GTG/core folder and couple of small cleanup like style >> comments, changing double underscope naming into a signal underscope >> naming for private variables. >> >> Can you review them? >> >> I have two questions: >> >> 1) What is the proper name of our GTG? Getting Things GNOME or Gettings >> Things GNOME? Some of our header files have the variant with -s It's Getting Things GNOME! (cf. https://live.gnome.org/gtg/manifesto) Gettings Things GNOME is erroneous. >> 2) Bertrand> Why does your code include many testing in the pattern >> >> if date == Date.no_date() or (date != Date.no_date() and date.is_fuzzy()): >> >> According the current implementation of our Date class, no_date is a >> fuzzy date and thus the condition equals to >> >> if date.is_fuzzy(): >> >> Is there any special reason for that? I was not expecting no_date to be considered as a fuzzy date. It's pretty counter-intuitive I'd say (when a date is said to be fuzzy, I'm expecting that it knows at least something about a given time, not that it is undefined). Now, given that implementation, I guess those lines can indeed be simplified, but most of all I think there should also be a comment in the Date class stating clearly that no_date is considered as fuzzy then. >> Izidor >> >> _______________________________________________ >> Mailing list: https://launchpad.net/~gtg-contributors >> Post to : [email protected] >> Unsubscribe : https://launchpad.net/~gtg-contributors >> More help : https://help.launchpad.net/ListHelp >> > > > -- > Nimit Shah, > B Tech 4th year, > Computer Engineering Department, > SVNIT Surat > www.dude-says.blogspot.com > > _______________________________________________ > Mailing list: https://launchpad.net/~gtg-contributors > Post to : [email protected] > Unsubscribe : https://launchpad.net/~gtg-contributors > More help : https://help.launchpad.net/ListHelp -- Bertrand Rousseau _______________________________________________ Mailing list: https://launchpad.net/~gtg-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~gtg-contributors More help : https://help.launchpad.net/ListHelp
