Review: Needs Fixing code, run I played with your patch.
First to say, you updated "trunk" of liblarch immediately and it was distributed into PPA and made people to report bug #1069963. Another thing is, that you should have increased LIBLARCH_API number both in GTG & liblarch. About performance. I measured it on my real tasks (220+): Current GTG & liblarch: real 0m4.775s user 0m4.384s sys 0m0.244s Viewcount: real 0m6.155s user 0m5.808s sys 0m0.260s It is a little bit slower, UI is slower a little bit too. It is not an order of magnitude, it is bearable. Please, get rid of commented code. Look at your diff and get rid of those print statetements or just commented code. I get an error message when I start GTG: "There's no filter called gtg-tags-sep" --> Please, solve it. I found a regression: Make a tag @a child of tag @b by drag-and-drop. While you do it, the main pane is refreshed two times - it is slow and the user can see it. In the trunk, the main pane is not refreshed. Same thing happens when you delete the last task in the tag -> the main pane is refreshed and it is so slow. Another regression is that the tags are not expanded by default. When you have a tag tree @a -> @b, tag @a should be expanded by default during the boot time. Another regression + performance issue: Try to search for "!not @gtg". I get 189 out of 213 results in trunk (althought initialy the count is 0). In your branch it is slow (I guess the refreshing something) but more important, it put there count 238 out of 213!!! Switching back and forth into workview and back doesn't help. (Workview shows correct count though) I would say it counts closed tasks as well. Another regression: Strat GTG with the firstboot tasks. Look at the "Tasks without tags" count -> 7. Now mark some tasks without tags as done. The count doesn't change although the count of all tasks does -> you can have 7 of 6 tasks if you want. I guess it would be similar regression. There are quite much work to do, it is not completed yet :) However, it looks promising! -- https://code.launchpad.net/~gtg/gtg/viewcount/+merge/130696 Your team Gtg developers is subscribed to branch lp:~gtg/gtg/viewcount. _______________________________________________ Mailing list: https://launchpad.net/~gtg Post to : [email protected] Unsubscribe : https://launchpad.net/~gtg More help : https://help.launchpad.net/ListHelp
