Hey Tristan,
thanks for sending this detailed status update. Here is some initial
feedback after playing with the branch for a few minutes:
1. intltool - I don't like it, and really want to avoid adding a
intltool dependency to GTK+. I've attached a small program that can
get the job done for the .ui files in your branch.
2. All the composite dialogs flash black and in wrong size when
mapped. I hope that is just an oversight, and can be corrected. I
don't think we can merge it like that
3. The print dialog segfaults.
4. The Pickers example in gtk3-demo has issues: the filechooser button
has the wrong height, and the directory chooser doesn't show up at
all. The filechooser also has an empy filter combo that should not be
visible.
5. The Color Chooser example in gtk3-demo has issues: the alpha slider
in the color editor has a round knob, instead of a pointy one.
6. The button order in the assistant is flipped.
#include <glib.h>
typedef struct {
GString *output;
gboolean translatable;
gchar *context;
gchar *comments;
GString *text;
} ParserData;
static void
start_element_handler (GMarkupParseContext *contexts,
const gchar *element_name,
const gchar **attribute_names,
const gchar **attribute_values,
gpointer user_data,
GError **error)
{
ParserData *data = user_data;
if (g_str_equal (element_name, "property"))
{
gboolean translatable;
gchar *context;
gchar *comments;
g_markup_collect_attributes (element_name,
attribute_names,
attribute_values,
error,
G_MARKUP_COLLECT_STRING, "name", NULL,
G_MARKUP_COLLECT_TRISTATE, "translatable", &translatable,
G_MARKUP_COLLECT_STRDUP|G_MARKUP_COLLECT_OPTIONAL, "context", &context,
G_MARKUP_COLLECT_STRDUP|G_MARKUP_COLLECT_OPTIONAL, "comments", &comments,
G_MARKUP_COLLECT_INVALID);
if (translatable == TRUE)
{
data->translatable = TRUE;
data->context = context;
data->comments = comments;
data->text = g_string_new ("");
}
}
}
static void
end_element_handler (GMarkupParseContext *context,
const gchar *element_name,
gpointer user_data,
GError **error)
{
ParserData *data = user_data;
if (!data->translatable)
return;
if (data->comments)
g_string_append_printf (data->output, "\n/* %s */\n",
data->comments);
if (data->context)
g_string_append_printf (data->output, "C_(\"%s\", \"%s\")\n",
data->context,
data->text->str);
else
g_string_append_printf (data->output, "N_(\"%s\")\n",
data->text->str);
g_free (data->comments);
g_free (data->context);
g_string_free (data->text, TRUE);
data->comments = NULL;
data->context = NULL;
data->text = NULL;
data->translatable = FALSE;
}
static void
text_handler (GMarkupParseContext *context,
const gchar *text,
gsize text_len,
gpointer user_data,
GError **error)
{
ParserData *data = user_data;
if (!data->translatable)
return;
g_string_append_len (data->text, text, text_len);
}
static const GMarkupParser parser = {
start_element_handler,
end_element_handler,
text_handler,
NULL,
NULL
};
int
main (int argc, char *argv[])
{
gchar *contents;
gsize length;
GError *error;
GMarkupParseContext *context;
ParserData data;
if (argc < 2)
{
g_printerr ("Expect a filename\n");
return 1;
}
error = NULL;
if (!g_file_get_contents (argv[1], &contents, &length, &error))
{
g_printerr ("%s\n", error->message);
g_error_free (error);
return 1;
}
data.output = g_string_new ("");
data.translatable = FALSE;
context = g_markup_parse_context_new (&parser, 0, &data, NULL);
if (!g_markup_parse_context_parse (context, contents, length, &error))
{
g_markup_parse_context_free (context);
g_free (contents);
g_printerr ("%s\n", error->message);
g_error_free (error);
return 1;
}
g_print ("%s", g_string_free (data.output, FALSE));
return 0;
}
_______________________________________________
gtk-devel-list mailing list
gtk-devel-list@gnome.org
https://mail.gnome.org/mailman/listinfo/gtk-devel-list
