hi; thank you for your patches!
patches for the GTK+ project are handled and reviewed on Bugzilla: https://bugzilla.gnome.org/enter_bug.cgi?product=gtk%2B could you please file a new bug and attach your patches there? also, you should follow the recommendations for contributions here: https://wiki.gnome.org/Git/CommitMessages https://wiki.gnome.org/Git/WorkingWithPatches again, thanks for your contribution to the GTK+ project! ciao, Emmanuele. On 11 March 2014 14:24, Bálint Réczey <bal...@balintreczey.hu> wrote: > Hi, > > Please consider accepting the attached patches. > > Thanks, > Balint > > > ---------- Forwarded message ---------- > From: Bálint Réczey <bal...@balintreczey.hu> > Date: 2014-03-03 20:02 GMT+01:00 > Subject: Re: Porting GTK+ app from defining custom stock items to > using GtkIconTheme > To: Stefan Salewski <m...@ssalewski.de> > Másolatot kap: gtk-l...@gnome.org > > > Hi Stefan, > > 2014-03-03 0:34 GMT+01:00 Stefan Salewski <m...@ssalewski.de>: >> On Sun, 2014-03-02 at 23:29 +0100, Bálint Réczey wrote: >>> The link I have sent in two of my emails points to a gerrit review, >>> where >>> I have marked the relevant parts. >>> Could you please check it? It should do as fine as a minimal example >>> to >>> experienced eyes. >> >> I saw the link already some days ago -- but I am only an average GTK >> developer, far from an expert... >> >> One remark: >> >> In your code: >> gtk_icon_theme_add_builtin_icon(pixmaps[i].name, GTK_ICON_SIZE_MENU, >> pixbuf); >> gtk_icon_theme_add_builtin_icon(pixmaps[i].name, >> GTK_ICON_SIZE_SMALL_TOOLBAR, pixbuf); >> >> From GTK documentation: >> https://developer.gnome.org/gtk3/stable/GtkIconTheme.html#gtk-icon-theme-add-builtin-icon >> >>>size: the size at which to register the icon (different images can be >>>registered for the same icon name at different sizes.) >> >> But you register the same pixbuf object for various sizes. >> >> It was my feeling, that you should specify not the desired, but the >> actual size. See bottom most answer here: >> >> http://stackoverflow.com/questions/12521134/gtktoolbutton-with-custom-icon-but-of-stock-icon-size > Thank you for the hints. The size was wrong for the icons, indeed. > The migration is almost perfect now, I just need to figure out why the > toolbar icons are not shown when they overflow the toolbar width. > > I have attached two minor patches for GTK+. One clarifies the size > parameter usage, one helps compiling GTK+ apps with -Wc++-compat. > > Cheers, > Balint > > _______________________________________________ > gtk-devel-list mailing list > gtk-devel-list@gnome.org > https://mail.gnome.org/mailman/listinfo/gtk-devel-list > -- W: http://www.emmanuelebassi.name B: http://blogs.gnome.org/ebassi/ _______________________________________________ gtk-devel-list mailing list gtk-devel-list@gnome.org https://mail.gnome.org/mailman/listinfo/gtk-devel-list
