Hi,
I would like to ask review for the following patch that it's been
in bugzilla for more than a year[1] waiting for review:
https://bugzilla.gnome.org/show_bug.cgi?id=710612
It's about making GtkTextView able to extend the text selection with the
mouse scrollwheel, which is currently not possible.
Regards,
From 3118ade9e1c27f69aac0cf99b8d429ba891996b9 Mon Sep 17 00:00:00 2001
From: Nelson Benitez Leon <nbenit...@gmail.com>
Date: Tue, 22 Oct 2013 12:24:55 +0200
Subject: [PATCH] GtkTextView: allow to extend text selection with mouse
scrollwheel
Fixes bug 710612
---
gtk/gtktextview.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/gtk/gtktextview.c b/gtk/gtktextview.c
index 96dca1d..cdf7503 100644
--- a/gtk/gtktextview.c
+++ b/gtk/gtktextview.c
@@ -8501,6 +8501,20 @@ gtk_text_view_value_changed (GtkAdjustment *adjustment,
priv->first_validate_idle = 0;
}
+ /* Allow to extend selection with mouse scrollwheel. Bug 710612 */
+ if (gtk_gesture_is_active (priv->drag_gesture))
+ {
+ GdkEvent *current_event;
+ current_event = gtk_get_current_event ();
+ if (current_event != NULL)
+ {
+ if (current_event->type == GDK_SCROLL)
+ move_mark_to_pointer_and_scroll (text_view, "insert");
+
+ gdk_event_free (current_event);
+ }
+ }
+
/* Finally we update the IM cursor location again, to ensure any
* changes made by the validation are pushed through.
*/
--
2.1.0
_______________________________________________
gtk-devel-list mailing list
gtk-devel-list@gnome.org
https://mail.gnome.org/mailman/listinfo/gtk-devel-list
