Hi, The first specifies source files shipped with the tarball. It should be extremely difficult to get into this position, so we rarely specify files in this way.
The second looks wrong -- libgio-2.0.la should have libgmodule-2.0.la as a dependency. None of the tools use libgmodule directly, it's GIO that needs GModule. That dependency might change in the future, since it's a private dependency of GIO. It doesn't make sense to specify as a dependency of the binaries to me. The third patch, unfortunately, seems bizarre as well -- $(glib_compile_resources) is found and set by configure.ac, so it must be there in order for the Makefile to have been generated. It doesn't make much sense to me to also check it in the Makefile. Let me know if you have any other questions. On Tue, Aug 4, 2015 at 8:05 AM, Shane McIntosh <mcint...@cs.queensu.ca> wrote: > Hi all, > > I’m part of a research team that's working on a tool that scans build systems > for missing dependencies. We ran a prototype of our tool on the GLib build > system, and detected a few bugs: > > https://bugzilla.gnome.org/show_bug.cgi?id=752239 > https://bugzilla.gnome.org/show_bug.cgi?id=752232 > https://bugzilla.gnome.org/show_bug.cgi?id=752227 > > We’ve attached patches that address the missing dependencies to those bug > reports. We hope that the patches are useful. It would be great if a GLib > maintainer could have a look, and get back to us! The feedback would be very > helpful for when we scale the approach out to larger build systems — perhaps > even scanning the whole of GTK+ or GNOME if there is interest. > > All the best, > -Shane > > http://shanemcintosh.org/ > _______________________________________________ > gtk-devel-list mailing list > gtk-devel-list@gnome.org > https://mail.gnome.org/mailman/listinfo/gtk-devel-list -- Jasper _______________________________________________ gtk-devel-list mailing list gtk-devel-list@gnome.org https://mail.gnome.org/mailman/listinfo/gtk-devel-list
