Hi Raphael, Raphael Manfredi <[EMAIL PROTECTED]> wrote: > * Added inclusion of "common.h" for FreeBSD 4.7 (utf8.c).
I wonder whether we have or need a policy for #include. It would have worked just by #includ'ing glib-missing.h. I tend to prefer the least possible number of inclusions for better dependency tracking - common.h includes many other stuff which isn't necessary here. I also think that config.h should be in scope of every file. IIRC, autoconf suggests to place #ifdef HAVE_CONFIG_H #include <config.h> #endif in this case even if not currently necessary. E.g., there's one example (which doesn't matter for GtkG, ATM): If you want to use more than 256 file descriptors with select() you would have to #define FD_SETSIZE before #include <sys/types.h>. Things like that would be defined during compile time (i.e., configure time) and should be put into config.h[,.in]. IMO, config.h is a good concept even if you don't use/like autoconf. Christian
msg00061/pgp00000.pgp
Description: PGP signature
