On Mon, 2003-03-10 at 04:49, clayton rollins wrote:
> Hi all,
> Two quick 'bug' reports.
>
> First, I just cvs'ed the latest sources and was dismayed to find that all
> uncompressed leaves are being rejected. (with 'prefer compressed' enabled.)
>
> I prefer the old behavior of allowing connections up to the limit, giving
> preference to compressed connections, if this was changed on purpose.
Whooops. It seems like I accidentially committed more than I intended to. Well, there is no low-watermark for leaves. I'll talk to the others and then decide whether to revert that modification.
So, I was right in thinking this was intended...
Well, on a preliminary judgement, it works out all right. (if uncompressed are allowed up to the original leaf amount then only allow compressed connections, I think it works a bit better.)
I probably would have only noticed the benefit, if I didn't forget to uncheck ultrapeer when I shut down before that reboot. (other software problems...)
If this is what you all decide to go with, I'd be fine with it; I just don't like to ban anyone completely. (banning *all* uncompressed leaves might hurt the gnet.)
(Especially if you factor in the extremely low connect-rate of some clients, notably gnucleus, [not to bash on swabby; I like that he had faith in the supporting nodes], this could do much to push new users away.)
> Secondly, I don't know if it's a big deal or not, but the function
> is_faked_download() is used implicitly in downloads_gui.c. I fixed it by
> making the downloads.c function available through its header file, though
> adding the code locally would help reduce the dependency on downloads.c.
It's not a big deal, but I'll fix it. --
Yeah, I didn't think so. (I ran the cvs for 45+ mins with no problem.)
Just thought I should mention it. just in case.
Thanks, Clayton
_________________________________________________________________
MSN 8 helps eliminate e-mail viruses. Get 2 months FREE*. http://join.msn.com/?page=features/virus
------------------------------------------------------- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf _______________________________________________ Gtk-gnutella-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/gtk-gnutella-devel
