Richard Hyde wrote:

Important ones:
1 - Use tabs instead of spaces to ident


Ah, the holy space V tabs debate.


:) 'debate'. The point is, in gtk-gnutella tabs are used instead of spaces everywhere. Not much of a debate, it is just that all files should look similair. Wether I like it or not. Same goes for everyone else. I think we should still make sure the gtk-gnutella code is consistent.
Of course I welcome all patches, but I urge everyone to read the STYLE document


One note though:
The document says people should use if (NULL == var).
This is something I personally don't like, and never used it in my own functions (parq). Neither is it used everywhere in the code. So I don't want to force everyone to use
if (NULL == var) instead of if (var == NULL). (So feel free to use the last one). However, if you patch an allready existing file, make sure keep the syntax of that file.


2 - Comment functions.


Will do.

Could you apply the patch OK, IE did I use of diff correctly? I'll
tidy-up the code and post you another patch.


Yes, the format of the patch (unified diff) was ok.

- Jeroen



-------------------------------------------------------
This SF.net email is sponsored by: SF.net Giveback Program.
SourceForge.net hosts over 70,000 Open Source Projects.
See the people who have HELPED US provide better services:
Click here: http://sourceforge.net/supporters.php
_______________________________________________
Gtk-gnutella-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/gtk-gnutella-devel

Reply via email to