Hi,

> main_gui.c:
> 
> I don't understand what the changes in main_gui.c do. It seems that you
> change the navi-tree menu... but what exactly do you change?
> 

I re-ordered the nav menu to make the first items Search, Downloads, and
Uploads  (instead of  gnutellaNet, Uploads, Downloads, Search...).  It
doesn't make sense to open the program in the gnutellaNet tab or to have
the most commonly used items in the middle of the list, the old order
wasn't even alphabetical! 

The code changes I made were just cut 'n' paste reordering as the nav
items were added using "append".  


> As for the bw settings: instead of coupling them to a "simplyfied gui"
> toggle, I would suggest to change the default visibility to "off"
> and leave it to the user to turn in on via the menu bar. How about that?

That makes a lot of sense... wow it's easy to ignore the simple
solutions :) 

> Maybe we could couple the visibility of "leaf traffic" to being in UP
> mode? Would that be good to do?

I'm not sure that would be too useful for folks.  I think it'd be
simpler to have all the progress bars controlled by the view menu as you
suggested (with the default being off).  I don't think normal users will
ever bother to learn what "leaf traffic" means.

> Note this: I don't reject that patch, but patches to glade and (btw.)
> the properties files I mostly apply by hand, using a text editor for
> the properties and glade for the gui stuff.
> 

Cool, that's super good to know. I'll make sure I'm more clear what
changes I've made to the gui in the future so something little I did in
glade doesn't get missed.


(Search buttons)
> Look at
> http://www.candledark.org/screens/screen2.jpg
> http://www.candledark.org/screens/screen3.jpg
> 
> What do you think?
> 

Looks good.  Some horizontal padding between the buttons (like we have
for the rest of the interface) would be good.  I wonder if we can just
say "Passive" instead of "New Passive".  Either way is ok though.


> When you force the bw displays off, then the options to show or hide
> them should also be removed from the gui (menu bar->view) since they
> no longer have any effect.
> 

Hehe, I thought of this today, in fact I even wrote a paragraph about
why it was maybe a good idea to do instead of what I submitted but
decided I would just include it with the next patch I sent.  However, it
sounds like this is a moot point if the bw displays are not going to be
controlled with the expert mode setting.


> It would be cleaner to change the props directly instead of calling
> update_stats_visibility(). It would save you the "prop_menus_to_change"
> array and it would make the stuff more understandable. With your code
> ...
> 
> That makes it more obvious that a property is changed and lets the rest
> of the gui/property code update the according gui elements as needed.
> Can you see what I mean?

Thanks for the info.  I see what your saying.  I though of this but went
the other way because 1) I'm scared of the stub stuff :)  2) There was
code written already so I figured I use it and 3) I wasn't sure the gui
would auto-update if I just changed the property, I'm glad it will, that
not only makes sense but will make future changes much easier.  I do see
what you're saying about clarity though, thanks.


So, please let me know if you want me to do anything else on this, but
it sounds like you have it done or almost done already.  Which is
great!  I think this will help out our novice users.

Emile

-- 
Computer Troubleshooting, New Computer Advice, Virus Clean-up,
Hardware/Software Installs, Web Design, Linux Installations:  Attune
Consulting can help.  
http://www.attuneconsulting.com 
[EMAIL PROTECTED]



-------------------------------------------------------
This SF.net email is sponsored by: IBM Linux Tutorials.
Become an expert in LINUX or just sharpen your skills.  Sign up for IBM's
Free Linux Tutorials.  Learn everything from the bash shell to sys admin.
Click now! http://ads.osdn.com/?ad_id=1278&alloc_id=3371&op=click
_______________________________________________
Gtk-gnutella-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/gtk-gnutella-devel

Reply via email to