Op 2-jun-04 om 10:19 heeft Thomas Schuerger het volgende geschreven:
Hi,
appended is a patch for GTKG that adds HSEP support to the GTK1 GUI.
Change log:
- added a "Horizon stats" frame to the GTK1 Gnet stats panel, which displays the reachable nodes, files and bytes within 1 to 10 hops (updated as often as the other stats on the stats panel)
Why not add this info in the gnutellaNet pane next to the node connection where also the number of Queries, Rx, TX etc is displayed.
Perhaps it would also be nice to have the number of files and bytes displayed in the lower left pane where currently the number of connections, uploads and downloads are displayed.
Question:- changed API documentation in hsep.c - added missing '\n's in printf() calls in hsep.c - renamed hsep_get_table() to hsep_get_global_table() in hsep.c
Missing:
- the column sizes of the horizon stats clist are not persistent yet
Note that I did not include the patch for the generated sourcecode file of the GUI. It needs to be rebuilt from the included glade file.
Please have a look whether what I did is OK or not. If it is OK, please commit the changes. I will then also add a similar frame to the GTK2 GUI. As always, any comments are welcome.
if (!hsep_check_monotony((hsep_triple *) messaget, max)) {
- printf("HSEP: Node %p's message's monotony check failed", n);
Is this an error due to invalid parsing or does this happen when we receive an invalid packet. If it is the last, it might be better to have it only printed when dbg is set. -> if (dbg) -> print
If it is invalid parsing while the packet is correct it should assert (I think).
It looks like some lines are wider then 80 chars, please use a maximum width of 80.
- Jeroen
------------------------------------------------------- This SF.Net email is sponsored by the new InstallShield X.
From Windows to Linux, servers to mobile, InstallShield X is the one
installation-authoring solution that does it all. Learn more and evaluate today! http://www.installshield.com/Dev2Dev/0504 _______________________________________________ Gtk-gnutella-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/gtk-gnutella-devel
