Christian Biere wrote: > Bill Pringlemeir wrote: > > [uploads.c 1.208 : line 1426] > > > buf = strchr(buf, '/'); > > - p = buf++; > I wanted to keep the code semantically identical to the previous revision. > However, increasing buf by one is an unnecessary micro-optimization and > I remove it because it might be a little confusing for no real performance > gain whatsoever.
Arrgs. This was no micro-optimization at all. Clayton Rollins discovered the bug I had introduced by removing the increment. A few lines later `buf'' gets assigned to the variable ``basename'' and now the '/' wasn't removed so that requests by name couldn't be served. Mea culpa. Thanks a lot to Clayton. -- Christian
pgpP2qEVil0mi.pgp
Description: PGP signature
