On 7-Sep-09, at 3:44 PM, Raphael Manfredi wrote: > Quoting Matthew Lye <m...@talkwireless.ca> from ml.softs.gtk- > gnutella.devel: > :More like this? It wasn't as difficult as I thought, once I got used > :to the functions. > > Yes, this is a correct patch. Thank you. > > I've committed it in SVN as r16961 with slight style corrections. > > Also I've addeed a provision to make sure the address of such > challenging > hosts is removed from the fresh/valid host caches, to avoid further > propagation of that address, but this is incomplete because I did not > parse X-Node or X-Listen-IP or X-My-Address to know the proper port... > > I've added it as a TODO locally, but if you want to contribute the > necessary patch... :-) Look at feed_host_cache_from_string() for > inspiration. > We can probably extract the parsing code from there to reuse it.
Sorry, I should have thought of this before I wrote the patch: although the situation with the patch is *better* in terms of the amount of Foxy clogging, it's a half-step back from the "ban.c" solution. GTKG still appears to get IP suggestions that lead to Foxy servents, presumably from third party servents. The problem is that when GTKG eventually tries one of these IPs, it results in a 503 response from the Foxy servent: > 09-09-07 23:25:44 (MESSAGE): ----Got outgoing handshaking headers > from TH.FOXY.NO.DE: > GNUTELLA/0.6 503 No QRP > User-Agent: Foxy 1.9.9.0 > Remote-IP: GTK.GNU.TEL.LA:PORT > X-Try-Hubs: 1ST.FOXY.NO.DE:PORT 2009-09-08T11:25Z, > 2ND.FOXY.NO.DE:PORT 2009-09-08T11:25Z, 3RD.FOXY.NO.DE:PORT... As you can see, the 503 header does not include an "X-Auth-Challenge" line; we've already failed the authentication by not establishing it ourselves. This means that Foxy is still periodically stuffing the host cache in a cascading manner. Matt ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ gtk-gnutella-devel mailing list gtk-gnutella-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/gtk-gnutella-devel
