On 03.10.2013 01:43, Brian Manning wrote:
> I've made a change to Gnome2 [3] that hardcodes the path to the Gnome2
> output directory under blib so EU::MM sorts enums.pod differently now
> when it generates the Makefile.  The change is working for me on older
> and current versions of EU::MM.

Thanks for your investigation.

> Torsten, can you look at this and see if this change is the right way
> to go?  There's also another '$(FULLEXT)/enums.pod' being used at the
> bottom of Makefile.PL; can it/should it be hardcoded to 'Gnome2' also?

I think it would be better to make enums.pod's dependence on the
existence of blib/lib/Gnome2 explicit, as per the attached patch.  I
tested this with EU::MM 6.57_05 and 6.78: both have the Makefile target
and hence the build succeeds.
>From 1547e9b2bf4f9a001a35552136bbcf2f33c9ea72 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Torsten=20Sch=C3=B6nfeld?= <kaffeeti...@gmx.de>
Date: Thu, 3 Oct 2013 21:49:44 +0200
Subject: [PATCH] Fix build: ensure existence of blib/lib/Gnome2 for enums.pod

---
 Makefile.PL | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile.PL b/Makefile.PL
index 8ef6e19..fdfdd12 100644
--- a/Makefile.PL
+++ b/Makefile.PL
@@ -138,7 +138,7 @@ sub MY::postamble {
 			'PERL_GNOME_VFS' => $build_reqs{'perl-Gnome2-VFS'},
 		)
           . "
-\$(INST_LIB)/\$(FULLEXT)/enums.pod : \$(BLIB_DONE) maps podifyenums.pl
+\$(INST_LIB)/\$(FULLEXT)/enums.pod : \$(BLIB_DONE) \$(INST_LIB)/\$(FULLEXT)/ maps podifyenums.pl
 	\$(PERLRUNINST) -M\$(NAME) podifyenums.pl \$(NAME) maps > \$@
 ";
 }
-- 
1.8.1.2

_______________________________________________
gtk-perl-list mailing list
gtk-perl-list@gnome.org
https://mail.gnome.org/mailman/listinfo/gtk-perl-list

Reply via email to