Hi Mario, On Sun, 2007-12-09 at 13:11 +0100, Mario Sopena Novales wrote: > sorry my comment made you code a new patch. I tried both and, as you > said, with your first patch the findbar does not appears when you > don't have the newet gtkhtml-sharp lib. So, I will go with the first.
No worries! > However, your patch needs to be in gnome-sharp before we apply it to > monodoc and we have to make sure the version we test is the one that > has your patch applied. Sounds good. I take it you mean gnome-desktop-sharp (instead of gnome-sharp)? > So, once it gets in gnome-sharp, the check > should be GTKHTML_SHARP_3_X instead of GTKHTML_SHARP_3_14. Anyone I should ping to get the patch in gnome-desktop-sharp? Thanks, Alvaro On 05/12/2007, Alvaro Ramirez <[EMAIL PROTECTED]> wrote: > > Hi Mario, > > > > > I think your patch misses if someone hits the Ctrl+F keystroke but > > > it does not have the gtkhtml-sharp version needed. It will be > > > presented with a useless findbar. > > > > hmmm... shouldn't be the case. If you build against older versions of > > gtkhtml, the menu items get hidden, which would prevent the key-bindings > > from working (??) > > > > #if (!GTKHTML_SHARP_3_14) > > ui ["find_separator"].Hide (); > > ui ["find_text"].Hide (); > > ui ["find_next"].Hide (); > > ui ["find_previous"].Hide (); > > #endif > > > > > > > We better avoid those situations > > > > The above seems to avoid the scenario you mentioned. In any case, I've > > added some more conditionals and removed the search bar from the > > container altogether (when building against older gtk-html). The > > downside to this is that browser.cs now has more #if's :( Have a look at > > the new patches. Let me know... > > > > Thanks, > > > > Alvaro > > > > _______________________________________________ Gtk-sharp-list maillist - [email protected] http://lists.ximian.com/mailman/listinfo/gtk-sharp-list
