On Oct 7, 2009, at 15:14, Andy Stewart wrote:

> Andy Stewart <lazycat.mana...@gmail.com> writes:
>
> Hi Axel,
>
> Have you push this patch?
> I have finish another new patch, i will send you new patch after you
> push this patch.

Sorry for the delay.

I've pushed the patch. However, could you check that:

- if the docs talk about a signal ::some-signal and you've bound this  
signal as someSignal, could you then also change the docs to use  
'someSignal' so the user is not confused and, more importantly, click  
on the definition?

- You use fromGList. This frees the passed-in list. Is that what is  
supposed to happen? (It probably is, unless the function returns a  
pointer to an internal GList. This is rare, however, and would be  
mentioned in the docs.) For instance, the function  
'windowGetIconList' is correct as it frees the list. However, you  
should remove the comment about in the docs about what to free.  
That's really not relevant (and confusing) for the Haskell user.

Please record a new patch if you fix anything. I still can't see your  
account on code.haskell.org (=hackage.haskell.org), although Duncan  
has asked for my permission.

Cheers,
Axel.


------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay 
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
Gtk2hs-devel mailing list
Gtk2hs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/gtk2hs-devel

Reply via email to