On Mon, Feb 17, 2014 at 8:19 AM, Axel Simon <axel.si...@in.tum.de> wrote: > HI, > > On Feb 17, 2014, at 2:12 PM, Donald Allen <donaldcal...@gmail.com> wrote: >>> >>> I think your documentation changes apply to both Gtk+ 2.x and Gtk+ 3.x. >> >> Not true. For example, on the page describing >> Graphics.UI.Gtk.Windows.Dialog, it says >> >> "Dialog boxes are created with a call to dialogNew or >> dialogNewWithButtons. dialogNewWithButtons is recommended; it allows >> you to set the dialog title, some convenient flags, and add simple >> buttons. >> >> If 'dialog' is a newly created dialog, the two primary areas of the >> window can be accessed using dialogGetUpper and dialogGetActionArea." >> >> dialogNewWithButtons doesn't exist in the gtk3 version, nor does >> dialogGetUpper. I intend to remove the references to both and add a >> reference to dialogGetContentArea, which is the gtk3 replacement for >> dialogGetUpper. >> >> So please answer my question: do I need to conditionalize my >> gtk3-specific changes? In other words, are you continuing to try to >> support both gtk2 and gtk3? >> > > Right. Well, I think for now the answer is "yes". If we abandon support for > Gtk+ 2.x then we should do this by going through all the code and remove code > between #ifs where the version is below 3. As long as this hasn't been done > (and there is no particular advantage to this, except cases like yours where > one has to be extra careful about documentation and cross-references), the > binding supports Gtk+ 2.x.
And I presume that whatever you use to generate html from the comments in the code sees the after-pre-processing version of the code? In other words, conditionalizing the comments will actually affect what appears on the hackage website? /Don ------------------------------------------------------------------------------ Android apps run on BlackBerry 10 Introducing the new BlackBerry 10.2.1 Runtime for Android apps. Now with support for Jelly Bean, Bluetooth, Mapview and more. Get your Android app in front of a whole new audience. Start now. http://pubads.g.doubleclick.net/gampad/clk?id=124407151&iu=/4140/ostg.clktrk _______________________________________________ Gtk2hs-devel mailing list Gtk2hs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/gtk2hs-devel
