Murray Cumming wrote: > On Wed, 2007-12-12 at 23:22 -0500, José Alburquerque wrote: > >> I worked a little on querying stream positions and duration so I >> modified the player example to print a "status line" showing the >> position/duration of the ogg stream. Would you be able to look at/check >> in this patch if it's ok? Thanks. >> > > I have checked that in, though I made some small changes. > > You wrapped > gboolean gst_element_query_position(GstElement *element, GstFormat > *format, gint64 *cur); > as > bool query_position(Format& format, ClockTime& position) > > Why the change of type for position? Is that an error in the gstreamer C > API? > > While working on the element query example (GADM 11.1 <http://gstreamer.freedesktop.org/data/doc/gstreamer/head/manual/html/chapter-queryevents.html#section-querying>), I noticed that, although gst_element_query_position() works with a gint64, the C macros used with the position (like GST_TIME_ARGS and GST_FORMAT_TIME in gstclock.h) imply that they are working with a GstClockTime. Since C++ is strongly typed and C is not, I'm thinking that the developers used gint64 and GstClockTime interchangeably. In C++ types are more enforced so I thought we might use Gst::ClockTime instead, but this might not be the best thing to do. What do you think?
-Jose _______________________________________________ gtkmm-list mailing list [email protected] http://mail.gnome.org/mailman/listinfo/gtkmm-list
