Thanks for your feedback, Murray. I guess you're right, the documentation doesn't explicitly forbid passing in both NULL (though it does forbid passing in both non-NULL), I guess I was just assuming that it doesn't make much sense to "guess_language" given nothing to guess from :)
But yes, either way, I've filed a bug: https://bugzilla.gnome.org/show_bug.cgi?id=624269 Cheers, Adrian On Tue, Jul 13, 2010 at 6:05 AM, Murray Cumming <[email protected]> wrote: > On Tue, 2010-07-13 at 04:49 -0400, Adrian Petrescu wrote: > > Hey guys, > > > > > > I'm working off the latest tagged release of libgtksourceviewmm, which > > is gtksourceviewmm-2.10.0, and noticing that there's a significant > > bug. > > > > > > In the SourceLanguageManager, there's supposed to be a > > "guess_language" function with the following implementation: > [snip] > > Yes, that is there, right? > > > The semantics are supposed to be that you pass in both parameters, but > > only one or the other are non-NULL (it doesn't know what to do if you > > specify both or neither). > > Because the parameters can be null, we should add method overloads that > omit the parameters. It may be necessary to add an extra method with a > different name for this. > > We might also want to pass NULL instead of "" when the strings are > empty. > > I don't see anything about not being able to specify non-NULL for both: > > http://library.gnome.org/devel/gtksourceview/stable/GtkSourceLanguageManager.html#gtk-source-language-manager-guess-language > > But please use bugzilla to report bugs or add patches. > > > -- > [email protected] > www.murrayc.com > www.openismus.com > >
_______________________________________________ gtkmm-list mailing list [email protected] http://mail.gnome.org/mailman/listinfo/gtkmm-list
