Update of /cvsroot/gtkpod/libgpod
In directory sc8-pr-cvs2.sourceforge.net:/tmp/cvs-serv21201
Modified Files:
ChangeLog README configure.ac
Log Message:
* When adding photos to the iPod the user may or may not want to
rotate the picture shown on the iPod screen, for example
deending on EXIF rotation value. This can now be achieved by
passing a new parameter 'rotation' to itdb_photodb_add_photo()
or itdb_photodb_add_photo_from_data(). (Valid values: 0, 90, 180,
270, rotation is counter-clockwise). These two functions now
also accept a GError pointer. As a consequence Itdb_Thumb had to
be extended with a field for the rotation value and
itdb_artwork_add_thumbnail have been extended to accept
@rotation and @error as well.
The actual rotation is carried out in
ithumb-writer.c/ithumb_writer_write_thumbnail() using
gdk_pixbuf_rotate_simple() and require gdk-pixbuf V2.6 or
higher.
In contrast, itdb_track_set_thumbnails() and
itdb_track_set_thumbnails_from_data have been left unchanged,
even though they could be extended to accept @rotation and
@error easily. Please let me know if this is wanted.
* configure.ac
src/itdb.h
src/itdb_artwork.c
src/itdb_photoalbum.c
src/itdb_track.c
src/ithumb-writer.c: implemented changes outlined above.
* tests/test-photos.c: added @rotation and @error to the
itdb_photodb_add_photo() call.
Index: ChangeLog
===================================================================
RCS file: /cvsroot/gtkpod/libgpod/ChangeLog,v
retrieving revision 1.158
retrieving revision 1.159
diff -u -d -r1.158 -r1.159
--- ChangeLog 12 Nov 2006 15:12:33 -0000 1.158
+++ ChangeLog 23 Nov 2006 15:02:57 -0000 1.159
@@ -1,3 +1,36 @@
+2006-11-23 Jorg Schuler <jcsjcs at users.sourceforge.net>
+
+ * When adding photos to the iPod the user may or may not want to
+ rotate the picture shown on the iPod screen, for example
+ deending on EXIF rotation value. This can now be achieved by
+ passing a new parameter 'rotation' to itdb_photodb_add_photo()
+ or itdb_photodb_add_photo_from_data(). (Valid values: 0, 90, 180,
+ 270, rotation is counter-clockwise). These two functions now
+ also accept a GError pointer. As a consequence Itdb_Thumb had to
+ be extended with a field for the rotation value and
+ itdb_artwork_add_thumbnail have been extended to accept
+ @rotation and @error as well.
+
+ The actual rotation is carried out in
+ ithumb-writer.c/ithumb_writer_write_thumbnail() using
+ gdk_pixbuf_rotate_simple() and require gdk-pixbuf V2.6 or
+ higher.
+
+ In contrast, itdb_track_set_thumbnails() and
+ itdb_track_set_thumbnails_from_data have been left unchanged,
+ even though they could be extended to accept @rotation and
+ @error easily. Please let me know if this is wanted.
+
+ * configure.ac
+ src/itdb.h
+ src/itdb_artwork.c
+ src/itdb_photoalbum.c
+ src/itdb_track.c
+ src/ithumb-writer.c: implemented changes outlined above.
+
+ * tests/test-photos.c: added @rotation and @error to the
+ itdb_photodb_add_photo() call.
+
2006-11-12 Jorg Schuler <jcsjcs at users.sourceforge.net>
* ithumb-writer.c (itdb_write_ithumb_files):
Index: README
===================================================================
RCS file: /cvsroot/gtkpod/libgpod/README,v
retrieving revision 1.7
retrieving revision 1.8
diff -u -d -r1.7 -r1.8
--- README 11 Dec 2005 14:11:18 -0000 1.7
+++ README 23 Nov 2006 15:02:57 -0000 1.8
@@ -124,12 +124,7 @@
need to add code either to libgpod or to gtkpod to make that work
properly.
-As for Photo Database handling (which is not dealt with currently), I
-agree it doesn't make sense to associate its parsing with an
-Itdb_ItunesDB object, and that a 'parallel' api mimicking somewhat the
-Track/Playlist stuff with Photo/Album entities would need to be
-designed, but I didn't work on that since, and I probably won't short
-term.
+...
People wanting more info can find lots of details on
http://ipodlinux.org/ITunesDB#Artwork_Database
@@ -137,3 +132,5 @@
I hope that's helpful,
Christophe
+
+----------------------------------------------------------------------
Index: configure.ac
===================================================================
RCS file: /cvsroot/gtkpod/libgpod/configure.ac,v
retrieving revision 1.40
retrieving revision 1.41
diff -u -d -r1.40 -r1.41
--- configure.ac 31 Oct 2006 14:14:09 -0000 1.40
+++ configure.ac 23 Nov 2006 15:02:57 -0000 1.41
@@ -74,7 +74,7 @@
esac], have_gdkpixbuf=yes)
AH_TEMPLATE([HAVE_GDKPIXBUF], [Whether gdk-pixbuf is installed, ArtworkDB
writing support will be disabled if it can't be found])
if test x$have_gdkpixbuf = xyes; then
- PKG_CHECK_MODULES(GDKPIXBUF, gdk-pixbuf-2.0, have_gdkpixbuf=yes,
have_gdkpixbuf=no)
+ PKG_CHECK_MODULES(GDKPIXBUF, gdk-pixbuf-2.0 >= 2.6.0, have_gdkpixbuf=yes,
have_gdkpixbuf=no)
if test x"$have_gdkpixbuf" = xyes; then
AC_DEFINE_UNQUOTED(HAVE_GDKPIXBUF, 1)
fi
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
gtkpod-cvs2 mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/gtkpod-cvs2
