Revision: 1648
http://gtkpod.svn.sourceforge.net/gtkpod/?rev=1648&view=rev
Author: tiffman
Date: 2007-07-15 06:26:21 -0700 (Sun, 15 Jul 2007)
Log Message:
-----------
Fixed memory leak: wasn't closing files in mp3_read_lame_tag.
Modified Paths:
--------------
gtkpod/branches/gapless_playback/ChangeLog_detailed
gtkpod/branches/gapless_playback/src/mp3file.c
Modified: gtkpod/branches/gapless_playback/ChangeLog_detailed
===================================================================
--- gtkpod/branches/gapless_playback/ChangeLog_detailed 2007-07-15 12:53:44 UTC
(rev 1647)
+++ gtkpod/branches/gapless_playback/ChangeLog_detailed 2007-07-15 13:26:21 UTC
(rev 1648)
@@ -1,5 +1,10 @@
2007-07-08 Michael Tiffany <tiffman at users.sourceforge.net>
+ * src/mp3file.c: fixed memory leak: wasn't closing files in
+ mp3_read_lame_tag.
+
+2007-07-08 Michael Tiffany <tiffman at users.sourceforge.net>
+
* src/mp3file.c: modified mp3_read_lame_tag() to check the info tag
crc and return the result of the check. Changed the replaygain and
gapless functions to check the return value and only use tag data if
Modified: gtkpod/branches/gapless_playback/src/mp3file.c
===================================================================
--- gtkpod/branches/gapless_playback/src/mp3file.c 2007-07-15 12:53:44 UTC
(rev 1647)
+++ gtkpod/branches/gapless_playback/src/mp3file.c 2007-07-15 13:26:21 UTC
(rev 1648)
@@ -2345,9 +2345,12 @@
lt->calculated_info_tag_crc = crc_compute(full_info_tag,
INFO_TAG_CRC_SIZE, 0x0000);
+ fclose(file);
return (lt->calculated_info_tag_crc == lt->info_tag_crc);
lt_fail:
+ if (file)
+ fclose(file);
return FALSE;
}
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
gtkpod-cvs2 mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/gtkpod-cvs2
