Revision: 1978
http://gtkpod.svn.sourceforge.net/gtkpod/?rev=1978&view=rev
Author: jcsjcs
Date: 2008-05-24 06:53:52 -0700 (Sat, 24 May 2008)
Log Message:
-----------
* src/file.c (video_thumbnail_setup_cache): fixed compiler warning
and possible memory leak.
* src/file.c (create_video_thumbnail): fixed possible memory leak.
Modified Paths:
--------------
gtkpod/trunk/ChangeLog
gtkpod/trunk/src/file.c
Modified: gtkpod/trunk/ChangeLog
===================================================================
--- gtkpod/trunk/ChangeLog 2008-05-24 09:18:53 UTC (rev 1977)
+++ gtkpod/trunk/ChangeLog 2008-05-24 13:53:52 UTC (rev 1978)
@@ -1,3 +1,10 @@
+2008-05-24 Jorg Schuler <jcsjcs at users.sourceforge.net>
+
+ * src/file.c (video_thumbnail_setup_cache): fixed compiler warning
+ and possible memory leak.
+
+ * src/file.c (create_video_thumbnail): fixed possible memory leak.
+
2008-05-22 Jorg Schuler <jcsjcs at users.sourceforge.net>
* src/confirmation.c (gtkpod_confirmation): switch wrapping on for
Modified: gtkpod/trunk/src/file.c
===================================================================
--- gtkpod/trunk/src/file.c 2008-05-24 09:18:53 UTC (rev 1977)
+++ gtkpod/trunk/src/file.c 2008-05-24 13:53:52 UTC (rev 1978)
@@ -1037,11 +1037,11 @@
if (!g_file_test (cachedir, G_FILE_TEST_IS_DIR) && (g_mkdir (cachedir,
0777) == -1))
{
gtkpod_warning (_("Could not create '%s'"), cachedir);
+ g_free (cachedir);
+ cachedir = NULL;
}
- else
- {
- return cachedir;
- }
+
+ return cachedir;
}
/*
@@ -1069,10 +1069,12 @@
* so we close it on succesful generation */
tmp_fn = g_build_filename (tdir, "thumb.XXXXXX", NULL);
g_free(tdir);
-
+ tdir = NULL;
+
if ((fd = g_mkstemp(tmp_fn)) == -1 || close(fd))
{
gtkpod_warning (_("Error creating thumbnail file"));
+ g_free (tmp_fn);
return NULL;
}
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
gtkpod-cvs2 mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/gtkpod-cvs2
