Revision: 2237
http://gtkpod.svn.sourceforge.net/gtkpod/?rev=2237&view=rev
Author: teuf
Date: 2009-01-21 21:52:54 +0000 (Wed, 21 Jan 2009)
Log Message:
-----------
Make sure write_hash58 isn't called with inappropriate ipods
Modified Paths:
--------------
libgpod/trunk/ChangeLog
libgpod/trunk/src/itdb_device.c
Modified: libgpod/trunk/ChangeLog
===================================================================
--- libgpod/trunk/ChangeLog 2009-01-21 21:52:20 UTC (rev 2236)
+++ libgpod/trunk/ChangeLog 2009-01-21 21:52:54 UTC (rev 2237)
@@ -1,5 +1,11 @@
2009-01-21 Christophe Fergeau <teuf at gnome.org>
+ * src/itdb_device.c: itdb_device_write_hash58 should only be called
+ on devices supporting this hash type, it's a programming error to
+ call it with something else
+
+2009-01-21 Christophe Fergeau <teuf at gnome.org>
+
* src/itdb_device.c: set the hashing scheme in
itdb_device_write_checksum instead of doing it in itdb_itunesdb,
allows more flexibility if we ever add different checksumming
Modified: libgpod/trunk/src/itdb_device.c
===================================================================
--- libgpod/trunk/src/itdb_device.c 2009-01-21 21:52:20 UTC (rev 2236)
+++ libgpod/trunk/src/itdb_device.c 2009-01-21 21:52:54 UTC (rev 2237)
@@ -1740,9 +1740,7 @@
gsize len;
MhbdHeader *header;
- if (itdb_device_get_checksum_type (device) != ITDB_CHECKSUM_HASH58) {
- return TRUE;
- }
+ g_assert (itdb_device_get_checksum_type (device) == ITDB_CHECKSUM_HASH58);
fwid = itdb_device_get_firewire_id (device);
if (fwid == 0) {
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
------------------------------------------------------------------------------
This SF.net email is sponsored by:
SourcForge Community
SourceForge wants to tell your story.
http://p.sf.net/sfu/sf-spreadtheword
_______________________________________________
gtkpod-cvs2 mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/gtkpod-cvs2
