commit 476beea2a0f09f1f42af74425c53e1f7feafa614
Author: phantomjinx <p.g.richard...@phantomjinx.co.uk>
Date: Tue Feb 15 19:00:43 2011 +0000
Memory leak fixes
* misc_playlist.c
* msg not being displayed to user and not being freed
* mp4file.c
* free netitle and title
* Thanks for Daniel Forsi for spotting leaks
libgtkpod/misc_playlist.c | 3 ++-
plugins/filetype_mp4/mp4file.c | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
---
diff --git a/libgtkpod/misc_playlist.c b/libgtkpod/misc_playlist.c
index 5403c13..545b662 100644
--- a/libgtkpod/misc_playlist.c
+++ b/libgtkpod/misc_playlist.c
@@ -1197,7 +1197,8 @@ static void delete_playlist_ok(struct DeleteData *dd) {
}
delete_playlist_cleanup(dd);
- gtkpod_tracks_statusbar_update();
+ gtkpod_statusbar_message(msg);
+ g_free(msg);
}
void delete_playlist_head(DeleteAction deleteaction) {
diff --git a/plugins/filetype_mp4/mp4file.c b/plugins/filetype_mp4/mp4file.c
index 07c34f1..725d777 100644
--- a/plugins/filetype_mp4/mp4file.c
+++ b/plugins/filetype_mp4/mp4file.c
@@ -660,7 +660,7 @@ Track *mp4_get_file_info(const gchar *mp4FileName) {
newtitle = g_strndup(&buffer[2], titlelength);
newtitle[titlelength] = '\0';
title = g_strdup(newtitle);
- free(newtitle);
+ g_free(newtitle);
}
}
@@ -668,6 +668,7 @@ Track *mp4_get_file_info(const gchar *mp4FileName) {
u_int64_t convertedsampletime =
MP4ConvertFromTrackTimestamp(mp4File, trackId,
sampletime, MP4_MILLISECONDS_TIME_SCALE);
itdb_chapterdata_add_chapter(chapterdata,
convertedsampletime, title);
+ g_free(title);
}
track->chapterdata = itdb_chapterdata_duplicate(chapterdata);
------------------------------------------------------------------------------
The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE:
Pinpoint memory and threading errors before they happen.
Find and fix more than 250 security defects in the development cycle.
Locate bottlenecks in serial and parallel code that limit performance.
http://p.sf.net/sfu/intel-dev2devfeb
_______________________________________________
gtkpod-cvs2 mailing list
gtkpod-cvs2@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/gtkpod-cvs2
