On Mon, Mar 21, 2016, at 09:39, Hans-Christoph Steiner wrote: > As for a plan for integrating this into NetCipher, I'd like to start > with the HttpURLConnection first, especially the SNI stuff. Ideally, it > would all fit into the existing TlsOnlySocket* stuff, without the need > for a Sni-specific subclass.
I am not completely clear where the rest of that thread left us. I am assuming that you want to go ahead with the HttpURLConnection code per your statement above. If so: - Just to confirm, you want this code to go into libnetcipher? - Is the package name that I chose (info.guardianproject.netcipher.hurl) OK, or do you want that changed? - Is the API that I am using basically acceptable to you, or do you want a major overhaul? Minor changes we can do after getting the code in your repo, but if you're looking for what might involve a top-to-bottom rewrite, I'd prefer to tackle that separately. - What sort of pull request granularity do you want? Fewer larger ones or many smaller ones? I'm a pull request n00b, so I apologize if the answer to that question should be obvious. - Do you want me to open a tracking issue for this work anywhere (and if so, where)? - Is there anything else that I should know before working on this and lobbing pull requests over to you? Thanks! -- Mark Murphy (a Commons Guy) https://commonsware.com | https://github.com/commonsguy https://commonsware.com/blog | https://twitter.com/commonsguy _______________________________________________ List info: https://lists.mayfirst.org/mailman/listinfo/guardian-dev To unsubscribe, email: [email protected]
