On Thu, Apr 18, 2024 at 10:55:27PM +0100, Richard W.M. Jones wrote: > On Thu, Apr 18, 2024 at 03:32:33PM -0500, Eric Blake wrote: > > On Thu, Apr 18, 2024 at 08:38:02PM +0100, Richard W.M. Jones wrote: > > > --- > > > tests/Makefile.am | 3 ++ > > > tests/test-shebang-crlf.sh | 59 ++++++++++++++++++++++++++++++++++++++ > > > tests/shebang-crlf.py | 2 ++ > > > 3 files changed, 64 insertions(+) > > > > > > > > --- /dev/null > > > +++ b/tests/shebang-crlf.py > > > @@ -0,0 +1,2 @@ > > > +#!../nbdkit python > > > +# See also: test-shebang-crlf.sh > > > -- > > > > Is checking in a bare CR to git going to cause problems to someone who > > checks out the repository on a platform where they choose to have git > > do CR munging? This seems like the sort of plugin where we are better > > off generating it on the fly rather than relying on the file surviving > > the user's environment. > > Yes I think that's a better idea. I'll respin this (probably > not this week) with the suggested change.
Upstream with your suggested fix hopefully in: https://gitlab.com/nbdkit/nbdkit/-/commit/6327c8dbe90b21804cd938f399410c201f8f56f4 https://gitlab.com/nbdkit/nbdkit/-/commit/f2ace4a1450b881953de4743f271622778361c37 https://gitlab.com/nbdkit/nbdkit/-/commit/1e483c15b22e93bb85b194a8dc279bbf814eda66 https://gitlab.com/nbdkit/nbdkit/-/commit/5d01b47d7a2b1fc92fa516c074bd4deadf1a1e7a and the last commit had a mistake, fixed later by: https://gitlab.com/nbdkit/nbdkit/-/commit/aade881287fbf5c7ef3539d2f01e0d6eea94a8a9 Rich. > > Otherwise, this series looks fine. > > > > -- > > Eric Blake, Principal Software Engineer > > Rich. > > -- > Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones > Read my programming and virtualization blog: http://rwmj.wordpress.com > Fedora Windows cross-compiler. Compile Windows programs, test, and > build Windows installers. Over 100 libraries supported. > http://fedoraproject.org/wiki/MinGW > _______________________________________________ > Libguestfs mailing list -- guestfs@lists.libguestfs.org > To unsubscribe send an email to guestfs-le...@lists.libguestfs.org -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com nbdkit - Flexible, fast NBD server with plugins https://gitlab.com/nbdkit/nbdkit _______________________________________________ Libguestfs mailing list -- guestfs@lists.libguestfs.org To unsubscribe send an email to guestfs-le...@lists.libguestfs.org
