On Mon, Jan 06, 2025 at 04:53:52PM +0000, Richard W.M. Jones wrote:
> The QueryAllocatedBlocks API has (another) frustrating feature.  It
> can only query whole "chunks" (128 sectors).  If the disk size is not
> aligned to the chunk size (say the size was 129 sectors) then there's
> a bit at the end which cannot be queried.  Furthermore, the API gives
> an error in this case instead of being helpful:
> 
>   VixDiskLib_QueryAllocatedBlocks: One of the parameters was invalid
> 
> Fixes: https://issues.redhat.com/browse/RHEL-71694
> ---
>  tests/Makefile.am                       |  5 +-
>  plugins/vddk/worker.c                   | 28 ++++++++-
>  tests/test-vddk-real-unaligned-chunk.sh | 82 +++++++++++++++++++++++++
>  3 files changed, 112 insertions(+), 3 deletions(-)

ACK v2 series

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization:  qemu.org | libguestfs.org
_______________________________________________
Libguestfs mailing list -- guestfs@lists.libguestfs.org
To unsubscribe send an email to guestfs-le...@lists.libguestfs.org

Reply via email to