On 2/10/25 11:28 AM, Richard W.M. Jones wrote:
> 
> Thanks, I pushed these as commit b3268a13bec.
> 

Great, thanks. I had some questions in the cover letter FYI


>> This may still break some really old cases. Notable `unconfigure_xen`
>> has a comment referencing RHEL 3, which lacks yum AFAIK. Which would
>> cause Guest_packages.uninstall_command to error.
>> 
>> Maybe we don't care about RHEL-3?
>> Or turn the error into a warning and be done with it?

Thoughts?

> I squashed them into one commit since they're logically a single
> change, and made a small whitespace change so that we don't go beyond
> 80 cols.
> 

Noted. Is there any `make syntax-check` or style checking tools I should
be aware of?

Thanks,
Cole
_______________________________________________
Libguestfs mailing list -- guestfs@lists.libguestfs.org
To unsubscribe send an email to guestfs-le...@lists.libguestfs.org

Reply via email to