Thanks Felix for support! Here I give my explicit feedback to avoid you lose any credit when you tried to clearly speak out your first feeling. Yes, I feel something not good as well. It's not what should be expected after sending a patch.
I think we need to stick to the code itself. And the code is simple enough to understand to everyone. And the code is tested to work in the described environment. That means I have finished my part. BTW, usually, the expected code review should be accurately hit what's critical in clear-cut language, nothing less nothing more. This is what called high quality review. Anyway, I think we have invested too much time on this simple patch. And I had made my alternative solution on it according to my previous mail. Best regards. On Wed, Aug 20, 2025, 23:02 Felix Lechner <felix.lech...@lease-up.com> wrote: > On Wed, Aug 20 2025, Maxime Devos wrote: > > > Anything in particular? > > No, the whole thing. Your responses were proficient and comprehensive > (too comprehensive for Nala) yet it seems to me that you lost sight of > the purpose of the transaction. > > Nala found a bug and, being a user, would like to see it fixed without > excessive discussion. It's not a contest. > > Nala, please chime in. I don't mean to put words into your mouth. > > Kind regards > Felix >
