Hi Neil,

Neil Jerram <[email protected]> writes:

> I finally got back to this.  I'm pretty sure the attached patch is now
> correct, so will commit in a couple of days unless anyone objects.

Thanks for working on it!  Please go ahead.

> * test-suite/tests/popen.test (open-input-pipe:no duplicate): Add
>   another pipe from parent to child, so that the child can finish by
>   reading from this.  Then the parent controls the child lifetime by
>   writing to this pipe.
>
>   test-suite/tests/popen.test (open-output-pipe:no duplicate): Add
>   another pipe from child to parent, and have the child finish by
>   endlessly writing into this.  Then the parent controls the child
>   lifetime by closing its end of the pipe, causing a broken pipe in
>   the child.

One nitpick: this entry doesn't completely follow the GNU ChangeLog
style.  Also, the rationale for the change belongs in comments in
`popen.test' rather than in the commit log.

Thanks,
Ludo'.


Reply via email to