Hello!

Thanks for working on this!

"Andy Wingo" <wi...@wingomac.bcn.oblong.net> writes:

> +#if BUILDING_LIBGUILE && HAVE_VISIBILITY
> +# define SCM_API extern __attribute__((__visibility__("default")))
> +#elif BUILDING_LIBGUILE && defined _MSC_VER

This should be:

  #if defined BUILDING_LIBGUILE && BUILDING_LIBGUILE && HAVE_VISIBILITY
  ...

Also, I'd have preferred `_GUILE_WITHIN_GUILE', which is clearly in
Guile's name space, and is similar to GMP's `__GMP_WITHIN_GMP' ("rule of
least surprise").  What do you think?

Thanks,
Ludo'.


Reply via email to