Hello,

Unused variables are compiled away to only their side effects. Yet
sometimes they are good for documentation. As in this case:

------------------------- module/language/assembly.scm -------------------------
index 683da6c..95f8a2d 100644
@@ -49,7 +49,7 @@
      (+ 1 *len-len* (string-length str)))
     ((load-array ,bv)
      (+ 1 *len-len* (bytevector-length bv)))
-    ((load-program ,nargs ,nrest ,nlocs ,labels ,len ,meta . ,code)
+    ((load-program _ _ _ _ ,len ,meta . _)
      (+ 1 *program-header-len* len (if meta (1- (byte-length meta)) 0)))
     ((,inst . _) (guard (>= (instruction-length inst) 0))
      (+ 1 (instruction-length inst)))


This is a bad change IMO. We should not contort our code to please some
mechanical idea of "good style".

Andy
-- 
http://wingolog.org/


Reply via email to