Hi, Andy Wingo <wi...@pobox.com> skribis:
> I have pushed a patch to master that changes the implementation of the > dynamic stack The “dynwind stack” actually (I misread it the first time.) > from being a linked list on the heap to being an actual stack. This > allows us to push items on the stack in many cases without allocating > memory at all. Sounds great! Could you please add comments in dynstack.c (above each function), and make sure to follow GCS-style (no hanging brace, for example)? Regarding comments, I see that <https://www.ohloh.net/p/guile> now ranks Guile as one of the least commented source code bases. There are many good reasons why we ought to do better here, IMO. WDYT? > This patch makes a simple "guile examples/web/debug-sxml.scm" server go > from serving 3215 reqs/s to 3830 reqs/s. (Using "ab -n 100000 -c100 > http://localhost:8080/"; on the same machine to test; the machine is my > laptop. By way of comparison, stable-2.0 does 3225 reqs/s on that > benchmark.) Nice! Did you try a micro-benchmark that would ‘dynamic-wind’ repeatedly? Thanks, Ludo’.
