l...@gnu.org (Ludovic Courtès) writes:
> Mark H Weaver <m...@netris.org> skribis:
>> l...@gnu.org (Ludovic Courtès) writes:
>>> Noah Lavine <noah.b.lav...@gmail.com> skribis:
>>>
>>>> 1. Alternate a lists of field names and values. The example becomes
>>>> (set-field p (person-address address-city) "Düsseldorf" (age) 32)
>>>
>>> I prefer this one. Perhaps it could be called ‘set-fields’, even.
>>>
>>> However, generating the most optimal code may prove to be complicated.
>>> For instance, you’d want:
>>>
>>> (set-fields p (person-address address-city) "Düsseldorf"
>>> (person-address address-street) "Bar")
>>>
>>> to expand to:
>>>
>>> (set-person-address p
>>> (let ((a (person-address p)))
>>> (set-fields a (address-city) "Düsseldorf"
>>> (address-street) "Bar")))
>>>
>>> But that would require knowledge of the relationship between
>>> ‘address-city’, ‘address-street’, and the underlying record type, etc.
>>
>> I don't understand why such knowledge is needed, or why this is
>> difficult. We have procedural macros. Simply sort the field-name-paths
>> lexicographically, split the sorted paths into groups with the same car,
>> and recurse. Am I missing something?
>
> Yes: nothing forces you to prefix names with ‘address-’ here.
As Noah pointed out, that doesn't matter. All you need to do is to
group together field-name-paths with equal cars and recurse. The field
names are irrelevant, as long as there exists an equality predicate on
names.
>> The associated runtime cost of searching for fields within the RTDs will
>> make functional records too slow for many purposes. To my mind, this is
>> absolutely unacceptable for a data type as fundamental as records. We
>> need to make functional record update as fast as we possibly can.
>
> Agreed. This is why the patch I posted take a purely syntactical
> approach.
>
> Though we must keep in mind that calling these setters involves a
> ‘make-struct’ call, which is already expensive. Does anyone have
> figures on the relative cost of (say) a function call compared to a
> small heap allocation?
The relevant cost to compare with is not simply a function call. In the
general case, 'set-fields' involves grouping together field-name-paths
with equal cars, looking up the field names in the RTDs, and recursing.
This code needs to be written either way, it's just a question of
whether it gets executed at run time or at expansion time.
'make-struct' may be expensive today, but there's no inherent reason why
it needs to be, so we can (and should) fix that later. That's no excuse
for making functional updates slower than they need to be. It's
relatively easy to make a smart procedural macro to generate optimal
code here.
>> Let's not make such a basic data structure slow out of laziness. If you
>> don't want to implement this, I'd be glad to.
>
> Implement what? The proposed ‘set-fields’?
Yes, or something like it. I don't have a strong opinion about the
exact syntax, so I'll let you all hash out those details.
Regards,
Mark
