Hi Mark, Thanks for splitting your work into small patches!
Mark H Weaver <m...@netris.org> skribis: > From 41e550e653d6a6a3793741b1fd19e6b569cdf1ce Mon Sep 17 00:00:00 2001 > From: Mark H Weaver <m...@netris.org> > Date: Mon, 22 Oct 2012 23:23:45 -0400 > Subject: [PATCH 1/9] Move array reader from arrays.c to read.c > > * libguile/arrays.c (read_decimal_integer): Move to read.c. > (scm_i_read_array): Remove. Incorporate the code into the > 'scm_read_array' static function in read.c. > > * libguile/arrays.h (scm_i_read_array): Remove prototype. > > * libguile/read.c (read_decimal_integer): Move here from read.c. > (scm_read_array): Incorporate the code from 'scm_i_read_array'. Call > 'scm_read_vector' and 'scm_read_sexp' instead of 'scm_read'. OK for me. Minor remarks: > +/* Read an array. This function can also read vectors and uniform > + vectors. Also, the conflict between '#f' and '#f32' and '#f64' is > + handled here. > + > + C is the first character read after the '#'. > +*/ Can you take this as an opportunity to fix the format of comments (no */ on a line of its own)? Thanks, Ludo’.
