Hi Andreas,
This first patch mostly looks good to me, except for some minor problems
with the commit log (see below) and more importantly:
* binary-ports.h needs to be added to the list of headers included by
libguile.h.
Andreas Rottmann <a.rottm...@gmx.at> writes:
> Currently, r6rs-ports.c provides procedures exported from `(ice-9
> binary-ports)'. However, in addition, it also provides
> `%make-transcoder', which is used by `(rnrs io ports)' via a "private
> import".
"Currently" -> "Previously"
"provides" -> "provided" (two places)
"is used by" -> "was used by"
> This change splits r6rs-ports.c into two parts, one specific to `(ice-9
> binary-ports)' and the other specific to `(rnrs io ports)'. This
> provides a place to put internal C-implemented helpers needed only in
> `(rnrs io ports)', thus allowing to eliminate the private import of
> `%make-transcoder'.
>
> * libguile/binary-port.c: New file, contains the most part of what has
> been in libguile/r6rs-ports.c for now.
"for now" -> "before now" or "previously".
> * libguile/binary-ports.h: Ditto for the header part.
>
> * libguile/r6rs-ports.c: Now contains just transcoded ports, as this API
> is not part of the `(ice-9 binary-ports)' module.
> * libguile/r6rs-ports.h: Now includes "libguile/binary-ports.h", and
> defines the extension registration and initialization functions.
>
> * libguile/Makefile.am: Add new files.
> ---
Entries for binary-ports.scm, ports.scm, and libguile.h should be added
to the commit log. It would also be good to mention that
"scm_register_r6rs_ports" was renamed to "scm_register_binary_ports".
Other than that, it looks good to me.
Thanks!
Mark
