Hello!

Note: I’m just familiarizing with the new code, so I may miss things,
and may make mostly superficial comments.

Andy Wingo <wi...@pobox.com> skribis:

> * module/Makefile.am:
> * module/system/vm/linker.scm: New file, split out of (system vm elf).
>
> * module/system/vm/elf.scm: Remove linking capabilities.
>
> * module/language/objcode/elf.scm: Adapt caller to use (system vm
>   linker).
>
> * test-suite/tests/linker.test: New test.

Looks good.  Would be nice to mention variable names too.

It seems elf.scm would benefit from byte structures similar to those
announced by Taylan on guile-user.  That’s more for aesthetics though,
and definitely not blocking.

Docstrings are lacking in those files.

Ludo’.


Reply via email to