Hi Mike, Mike Gran <spk...@yahoo.com> writes:
> Starting in the 2.2.x series, the Guile executable calls > setlocale(LC_ALL,"") on startup except when the GUILE_INSTALL_LOCALE > environment variable is set to '0'. > > This leads to a call to scm_shell that converts command line arguments > to Guile strings using the current locale. But in doing so, it calls > a function environ_locale_charset() that presumes that setlocale > hasn't been called. This appears to be obsolete, and probably be > replaced with just a call to gnulib's locale_charset(). > > It is a bit of an issue because it would prevent a possible future > update to gnulib, which no longer provides the get_charset_aliases() > procedure on which environ_locale_charset() has depended. > > If there is no objection, I'd like to remove environ_locale_charset(). Sounds good to me, go ahead. The comment above the only use of 'environ_locale_charset' also makes it clear that the plan was to remove this hack before 2.2. > But doing this would theoretically lead to a user-visible change. If > there were a user that had set the GUILE_INSTALL_LOCALE environment > variable to zero, intentionally bringing up Guile in the "C" locale, > but, still relied on Guile parsing non-ASCII command line arguments in > the environment's LANG-specified locale, it might lead to a different > behavior. I'm not worried about it, but I appreciate your attention to detail! Thanks, Mark