On Tue, Dec 29, 2020 at 07:50:05PM -0600, Rob Browning wrote:
> * doc/ref/posix.texi: Document mkdtemp! and scm_mkdtemp.
> * libguile/filesys.c: (mkdtemp!, scm_mkdtemp): New functions.
> 
> Signed-off-by: Rob Browning <r...@defaultvalue.org>

Hi Rob,

Since mkdtemp already returns a string of the new directory name,
it might be more scheme-like to not modify the input string, and instead
just return the new directory name.

Also, I don't know how universal mkdtemp is. It does exist in Linux and
OpenBSD, but, I'm not sure about all platforms. So a configure check
might not be amiss.

I'll send a reworked patch for you to consider.

Regards,
Mike Gran

Reply via email to