Vijay Marupudi schreef op wo 19-01-2022 om 10:44 [-0500]: > > If no copyright assignment has happend, then the copyright still > > belongs to the author > > -- from the Git repository's LICENSE: Copyright © Adam Nelson > > (2020)). > > While possibly you might have made some small changes to > > flexvectors, > > it seems that most code is preserved, so at most a ‘© FSF’ line > > could > > be added (*), however, the copyright line ‘© Adam Nelson’ would > > need to > > remain, otherwise the copyright lines are misleading. > > > > (*) This assumes you did copyright assignment to the FSF, otherwise > > ‘© Vijay Marupudi’. > > That's fair, thanks for looking into it! I was unaware of where to > include that information. I have added Adam Nelson and my name (can > remove this if necessary, just did it to be complete) to the license > comments and switched the `srfi-214.scm' file to the expat license > for > now. > > Note that I kept the GPL license in the srfi-214.test file, given > that the README in test-suite/README says: > > > Please write more Guile tests, and send them to bug-gu...@gnu.org. > > We'll merge them into the distribution. All test suites must be > > licensed for our use under the GPL, but I don't think I'm going to > > collect assignment papers for them.
Guile's README cannot override the law, so the expat license text would need to remain. I think test-suite/README is primarily concerned license compatibility and consistency, so I guess for code from external sources, the ‘let GPL be the license’ requirement can be relaxed somewhat. For example, see tests/srfi-27.test and tests/srfi-41.test -- they appear to be Expat. Something I forgot to mention: documentation! Would you be up to documenting flexvectors in Guile (in ‘6.6 Datatypes’ I presume, after ‘vlists’ maybe, with a cross-reference from ‘7.5 SRFI Support Modules’)? > I have not assigned my copyright to the FSF, but can do so if > necessary. As I understand it, a maintainer will inform you on what you need to sign, etc -- it's a process initiated by the maintainer, not the contributor.
signature.asc
Description: This is a digitally signed message part
