On 10/2/24 6:48 AM, Dr. Arne Babenhauserheide wrote:
Matt Wette <matt.we...@gmail.com> writes:
On 3/11/24 6:50 AM, Matt Wette wrote:
On 3/10/24 6:01 PM, Dr. Arne Babenhauserheide wrote:
Hi,
It’s been two months now, did anyone get to review this patch?
It’s small and it gives an instant improvement when using Guile in Emacs
orgmode babel sourceblocks that get evaluated on export.
Best wishes,
Arne
I did look at it. Another solution, I prefer, is generate a global
urrent-info-port object and
provide a command-line option to make that a file or /dev/null. Send
the welcome and
auto-compile messages to (current-info-port).
I had a patch for this at one time, but can't find it right now.
I found it. Here is a link:
https://github.com/mwette/guile-contrib/blob/main/patch/3.0.9/info-port.patch
The patch looks almost good to go to me.
But this looks wrong:
@@ -524,7 +524,7 @@ scm_set_current_input_port (SCM port)
SCM
scm_set_current_output_port (SCM port)
-#define FUNC_NAME "scm-set-current-output-port"
+#define FUNC_NAME "set-current-output-port"
{
SCM ooutp = scm_fluid_ref (cur_outport_fluid);
port = SCM_COERCE_OUTPORT (port);
If you compare to the input-port and error-port analogs you may come to
the conclusion I did.
Also, I think some of this code is no longer used. There may be
opportunity to remove some.
There’s also whitespace changes mixed in.
I apologize for that. I had (add-to-list 'write-file-functions
'delete-trailing-whitespace)
in my emacs init file. I have since removed this feature to remove
trailing whitespace.
modified module/ice-9/boot-9.scm
@@ -190,6 +190,13 @@ This is handy for tracing function calls, e.g.:
(newline (current-warning-port))
(car (last-pair stuff)))
+(define (info . stuff)
+ (newline (current-info-port))
+ (display ";;; FYI " (current-info-port))
+ (display stuff (current-info-port))
+ (newline (current-info-port))
+ (car (last-pair stuff)))
+
The canonical prefix is INFO, I think. So maybe
+ (display ";;; INFO " (current-info-port))
?
These sound fine to me. Thanks for the consideration.
Matt
