David Thompson <[email protected]> skribis:
> Finally got around to finishing up this package. I ran the example
> programs shipped with guile-opengl and confirmed that they work as
> expected. :)
>
> How does it look?
Looks good to me! One comment:
> + (define (dynamic-link-substitute file lib input)
> + (substitute* file
> + (((string-append "dynamic-link \"" lib "\""))
> + (string-append "dynamic-link \""
> + (assoc-ref inputs input)
> + "/lib/" lib "\""))))
Patterns in ‘substitute*’ are supposed to be literals.
Wouldn’t it work to do something like:
(substitute* file
(("dynamic-link \"lib[a-zA-Z]+\" _ libname)
(string-append ...)))
?
Thanks,
Ludo’.