Cyrill Schenkel <[email protected]> skribis:
> From b2f37807cbf4fa150272c5ff77eba7a8aeecfcef Mon Sep 17 00:00:00 2001
> From: Cyrill Schenkel <[email protected]>
> Date: Tue, 1 Jul 2014 12:02:26 +0200
> Subject: [PATCH] gnu: Add cmatrix.
>
> * gnu-system.am (GNU_SYSTEM_MODULES): Add new package.
> * gnu/packages/cmatrix.scm: New file.
[...]
> +(define-module (gnu packages acl)
Copy/paste error here.
Also, what about putting it in games.scm instead?
> + (build-system gnu-build-system)
> + (arguments
> + '(#:phases
> + (alist-cons-before
> + 'patch-source-shebangs 'autoreconf
> + (lambda args
> + (system* "autoreconf" "-fi"))
> + %standard-phases)))
This shouldn’t be needed because the tarballs includes ./configure,
Makefile.in, etc.
> + (inputs `(("ncurses" ,ncurses)
> + ("autoconf" ,autoconf)
> + ("automake" ,automake)))
Likewise: no need to depend on Autoconf and Automake.
> + (synopsis "CMatrix simulates the display from \"The Matrix\"")
In general the synopsis shouldn’t repeat the package name, so:
Simulate the display from \"The Matrix\"
Could you send an updated patch?
Thanks!
Ludo’.
