John Darrington <[email protected]> skribis:
> * gnu/packages/gimp.scm (gegl, gimp): New variables.
Great, looks good to me!
[...]
> + (lambda _
> + ;; This test program seems to crash on exit. Specifically, whilst
> + ;; g_object_unreffing bufferA and bufferB - This seems to be a bug
> in
> + ;; the destructor. This is just a test program so will not have
> any
> + ;; wider effect, although might be hiding another problem. The
> + ;; developers view is: "No released version is expected to be
> + ;; stable. Use the version from git" Go figure!!
> + (substitute* "tools/img_cmp.c"
> + (("g_object_unref \\(buffer.\\);") ""))
Could you add a link to the discussion or PR (if any?).
> + (arguments
> + `(#:configure-flags
> + `("--disable-python" ))) ; We don't have pygtk which seems to be
> needed for this feature
Line too long, please move the comment above.
> + (synopsis "Image manipulation program.")
No period here.
> + (description "GIMP is the GNU Image Manipulation Program. It is a freely
> +distributed piece of software for such tasks as photo retouching, image
> +composition and image authoring.")
Two spaces after end-of-sentence period.
> + (license license:gpl3+))) ; Some files are LGPLv3+
Comment all lower-case, or period at the end of sentence.
OK to push with these changes!
Ludo’.
