Ludovic Courtès writes:

> Ricardo Wurmus <ricardo.wur...@mdc-berlin.de> skribis:
>
>> I wrote the author an email to ask whether this can be fixed upstream
>> for other architectures than x86_64.  Until then should I just declare
>> x86_64 as the only supported architecture?
>
> Probably yes, with a comment pointing to this discussion and possibly
> the one with the author(s).

This may not even be necessary; the developer replied with a hint and
attached is a patch that should fix the build on non-x86_64
architectures.  It builds fine locally with

    ./pre-inst-env guix build --system=i686-linux hisat

Does this look okay?

~~ Ricardo

>From 5a73d260fcff839f5d07ef4ae684c78c4660f3d3 Mon Sep 17 00:00:00 2001
From: Ricardo Wurmus <ricardo.wur...@mdc-berlin.de>
Date: Thu, 12 Feb 2015 11:58:40 +0100
Subject: [PATCH] gnu: hisat: fix build on non-x86_64.

* gnu/packages/bioinformatics.scm (hisat): Add "POPCNT_CAPABILITY=0" to
  make-flags on architectures other than x86_64.
---
 gnu/packages/bioinformatics.scm | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/bioinformatics.scm b/gnu/packages/bioinformatics.scm
index 48bb9dd..f384cb8 100644
--- a/gnu/packages/bioinformatics.scm
+++ b/gnu/packages/bioinformatics.scm
@@ -252,8 +252,15 @@ Illumina, Roche 454, and the SOLiD platform.")
                 "1k381ydranqxp09yf2y7w1d0chz5d59vb6jchi89hbb0prq19lk5"))))
     (build-system gnu-build-system)
     (arguments
-     '(#:tests? #f ;no check target
-       #:make-flags '("allall")
+     `(#:tests? #f ;no check target
+       #:make-flags '("allall"
+                      ;; Disable unsupported `popcnt' instructions on
+                      ;; architectures other than x86_64
+                      ,@(if (string-prefix? "x86_64"
+                                            (or (%current-target-system)
+                                                (%current-system)))
+                            '()
+                            '("POPCNT_CAPABILITY=0")))
        #:phases
        (alist-replace
         'unpack
-- 
2.1.0

Reply via email to