宋文武 <[email protected]> writes: > 2015-03-02 7:47 GMT+08:00 Paul van der Walt <[email protected]>: >> * gnu/packages/pdf.scm (djvulibre): New variable. >> --- >> gnu/packages/pdf.scm | 22 ++++++++++++++++++++++ >> 1 file changed, 22 insertions(+) >> >> diff --git a/gnu/packages/pdf.scm b/gnu/packages/pdf.scm >> index 7b4f2ab..76c77d9 100644 >> --- a/gnu/packages/pdf.scm >> +++ b/gnu/packages/pdf.scm >> @@ -2,6 +2,7 @@ >> ;;; Copyright © 2013, 2015 Andreas Enge <[email protected]> >> ;;; Copyright © 2014 Mark H Weaver <[email protected]> >> ;;; Copyright © 2014, 2015 Ricardo Wurmus <[email protected]> >> +;;; Copyright © 2015 Paul van der Walt <[email protected]> >> ;;; >> ;;; This file is part of GNU Guix. >> ;;; >> @@ -143,6 +144,27 @@ >> (license license:gpl3) ; or gpl2, but not gpl2+ >> (home-page "http://www.foolabs.com/xpdf/";))) >> >> + >> +
Just one blank line between package definitions. >> +(define-public djvulibre >> + (package >> + (name "djvulibre") >> + (version "3.5.27") >> + (source (origin >> + (method url-fetch) >> + (uri (string-append >> "mirror://sourceforge/djvulibre/djvulibre-" >> + version ".tar.gz")) >> + (sha256 >> + (base32 >> + "0psh3zl9dj4n4r3lx25390nx34xz0bg0ql48zdskhq354ljni5p6")))) >> + (build-system gnu-build-system) >> + (home-page "http://djvu.sourceforge.net/";) >> + (synopsis "DjVuLibre is a GPL implementation of DjVu, a document >> format.") > Synposis is too long, and shouldn't contain package name, end with peroid, > etc. > Perhaps just "Implementation of DjVu"? I would suggest "Implementation of the DjVu document format" for the sake of those who aren't familiar with DjVu. Otherwise I agree with 宋文武's suggestions. Can you send an updated patch? Thanks! Mark
