Cyril Roelandt <tipec...@gmail.com> skribis:

> * guix/import/pypi.scm (compute-inputs, guess-requirements): New procedures.

Just some superficial comments.  David, anything else?

> +(define (guix-hash-url filename)
> +  "Return the hash of FILENAME in nix-base32 format."
> +  (bytevector->nix-base32-string
> +   (call-with-input-file filename port-sha256)))

Please remove and use:

  (bytevector->nix-base32-string (file-sha256 file))

> +(define (guix-name name)

‘python->package-name’?  + docstring

Could you augment tests/pypi.scm with a test where dependencies are
parsed?

Thanks!

Ludo’.

Reply via email to