On Sun, 29 Mar 2015 15:49:42 +0200 [email protected] (Ludovic Courtès) wrote: > Eric Bavier <[email protected]> skribis: > > > * gnu/packages/databases.scm (unqlite): New variable. > > [...] > > > + ;; Contiains bug-fixes against the official release, and has > > an > ^^^ ^ > Typo.
Thanks. > > + ;; autotooled build system. > > + (uri (string-append > > "https://github.com/aidin36/tocc/releases/"; > > + "download/v1.0.0/" > > + "unqlite-unofficial-" version ".tar.gz")) > > Still, it seems that we should be using the official version no? The official distribution is somewhat of a mess. The zip archive requires a patch that must be applied during a build step because our patch-and-repack can't handle "tarbombs". There are not installation scripts, and the trivial-build-system is much more verbose. > > + (synopsis "NoSQL database engine") > > “NoSQL” says what it’s not, but not what it is. Maybe “In-memory > key/value database” (IIUC) or something to that effect? Yes, that would be more descriptive. Perhaps "In-memory key/value and document store". > The rest LGTM. > > Thanks! Thank you for the review. `~Eric
