Hi Andy!
Here are some more comments to add to David's:
Andy Wingo <wi...@pobox.com> writes:
> From 4725d267b7c18bc4ba4294f90336871311386bb2 Mon Sep 17 00:00:00 2001
> From: Andy Wingo <wi...@pobox.com>
> Date: Sat, 4 Apr 2015 21:48:01 +0200
> Subject: [PATCH 2/3] Add upower package.
By our conventions, we write this first line as: "gnu: Add upower."
> * gnu/packages/gnome.scm (upower): New variable.
> * gnu/packages/patches/upower-builddir.patch: New patch.
The patch also needs to be added to 'dist_patch_DATA' in gnu-system.am.
David Thompson <dthomps...@worcester.edu> wrote:
> Could you add a comment about the upstream status of this patch, perhaps
> with a URL pointing to the relevant bug tracker, if applicable?
Agreed, but I think this should go in the top of the patch file rather
than in the package definition itself.
Thanks!
Mark
